Remove cloud emoji from title and use emoji directly as favicon#16
Conversation
|
@LindseyB 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: LindseyB <33750+LindseyB@users.noreply.github.com>
- Removed ☁️ from the <title> tag in public/index.html - Created favicon.svg with cloud design - Updated favicon link in HTML with proper MIME type - Added .gitignore entry for build directory - Tested changes work correctly in both dev and build modes Co-authored-by: LindseyB <33750+LindseyB@users.noreply.github.com>
| <link rel="icon" href="%PUBLIC_URL%/favicon.svg" type="image/svg+xml" /> | ||
| <link rel="icon" href="%PUBLIC_URL%/favicon.svg" /> |
There was a problem hiding this comment.
Instead of creating an SVG and using it why not just use the emoji directly like so:
<link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 100 100%22><text y=%22.9em%22 font-size=%2290%22>☁️</text></svg>">There was a problem hiding this comment.
@copilot Instead of creating an SVG and using it why not just use the emoji directly like so:
<link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%220 0 100 100%22><text y=%22.9em%22 font-size=%2290%22>☁️</text></svg>">There was a problem hiding this comment.
Good suggestion! I've updated the implementation to use the cloud emoji ☁️ directly as a favicon using a data URI instead of creating a separate SVG file. This is much simpler and cleaner. The emoji now appears as the favicon in the browser tab while keeping the title text clean.
Changes made in commit a1c51db:
- Replaced the separate
favicon.svgfile with an inline SVG data URI containing the cloud emoji - Simplified the favicon link to use the emoji directly
- Maintained the same visual result with a cleaner implementation
Co-authored-by: LindseyB <33750+LindseyB@users.noreply.github.com>
This PR addresses the issue where the cloud emoji was displayed in the browser tab title instead of being used as a favicon.
Changes Made
Removed cloud emoji from HTML title: Changed
<title>☁️ Hush - Breathing Exercise</title>to<title>Hush - Breathing Exercise</title>inpublic/index.htmlUse cloud emoji directly as favicon: Instead of creating a separate SVG file, the cloud emoji ☁️ is now used directly as a favicon through an inline SVG data URI:
Result
The implementation is clean and minimal, properly separating the title text from the visual icon representation while maintaining all existing functionality.
Fixes #15.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.