fix(workflows): replace invalid trim() in LGTM matcher [DOPS-600] - #2
Merged
Conversation
| github.event_name == 'issue_comment' && | ||
| github.event.issue.pull_request && | ||
| contains(fromJSON('["LGTM","lgtm","Lgtm"]'), trim(github.event.comment.body)) | ||
| (contains(github.event.comment.body, 'LGTM') || contains(github.event.comment.body, 'lgtm')) |
There was a problem hiding this comment.
Bug: The workflow trigger condition incorrectly uses a substring match for "LGTM", which can cause it to run on non-approval comments.
Severity: MEDIUM
Suggested Fix
Revert to the previous logic using contains(fromJSON('["LGTM", "lgtm", "Lgtm"]'), trim(github.event.comment.body)) to perform an exact match against a list of approval strings. This prevents unintended triggers from comments that only contain the approval text as a substring.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .github/workflows/merge-on-green.yml#L24
Potential issue: The workflow trigger condition was changed from an exact match against
an array of approval strings to a substring search. This is overly permissive and will
cause the merge workflow to trigger on comments that are not approvals but contain the
substring "LGTM", such as "This is NOT LGTM". Additionally, the mixed-case `Lgtm`
variant was removed from the condition, so that specific approval comment will no longer
trigger the workflow.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trim() is not a valid GHA expression — silently broke LGTM-by-comment merge. See LocumTenens-com/ltx#117 for source fix.
Test plan