Skip to content
This repository was archived by the owner on Nov 13, 2025. It is now read-only.

feat: make SendTimeout effect#32

Merged
ArgoZhang merged 6 commits into
masterfrom
feat-send
Sep 18, 2025
Merged

feat: make SendTimeout effect#32
ArgoZhang merged 6 commits into
masterfrom
feat-send

Conversation

@ArgoZhang

Copy link
Copy Markdown
Member

Link issues

fixes #31

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Copilot AI review requested due to automatic review settings September 18, 2025 01:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a SendTimeout feature for the TCP socket client, allowing users to configure a timeout for send operations. The implementation adds timeout logic to the SendAsync method and updates corresponding test cases.

Key changes:

  • Adds timeout functionality to the SendAsync method using CancellationTokenSource
  • Updates test cases to use the new timeout feature and modernized async receive methods
  • Replaces buffer-based receive operations with direct memory-based operations in tests

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Longbow.TcpSocket/Interface/DefaultTcpSocketClient.cs Implements SendTimeout logic in SendAsync method using linked cancellation tokens
test/UnitTestTcpSocket/TcpSocketFactoryTest.cs Updates tests to set SendTimeout and modernizes receive operations to use memory-based APIs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/Longbow.TcpSocket/Interface/DefaultTcpSocketClient.cs
@ArgoZhang ArgoZhang merged commit 52e6da0 into master Sep 18, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the feat-send branch September 18, 2025 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: make SendTimeout effect

2 participants