This repository was archived by the owner on Nov 13, 2025. It is now read-only.
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes SendTimeout and ReceiveTimeout options from the TcpSocket library, implementing a more efficient async socket handling approach using IValueTaskSource pattern instead of TaskCompletionSource.
- Refactored Sender and Receiver classes to inherit from SocketAsyncEventArgs and implement IValueTaskSource pattern
- Removed timeout-related code from send/receive operations
- Updated package references from Microsoft.Extensions.Options.ConfigurationExtensions to Microsoft.Extensions.Options
- Modified buffer handling in extension methods to use ArrayPool instead of MemoryPool
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| TcpSocketFactoryTest.cs | Added new test for OnCompleted method, removed timeout-related tests, updated existing test expectations |
| Longbow.TcpSocket.csproj | Updated version and simplified package references |
| Sender.cs | Complete rewrite to use IValueTaskSource pattern with chunked sending logic |
| Receiver.cs | Complete rewrite to use IValueTaskSource pattern, simplified error handling |
| DefaultTcpSocketClient.cs | Removed timeout logic from send/receive operations |
| ITcpSocketClientExtensions.cs | Changed from MemoryPool to ArrayPool for buffer management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #33
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge