Skip to content
This repository was archived by the owner on Nov 13, 2025. It is now read-only.

feat: redesign AutoReceive function#36

Merged
ArgoZhang merged 7 commits into
masterfrom
refactor-auto
Sep 24, 2025
Merged

feat: redesign AutoReceive function#36
ArgoZhang merged 7 commits into
masterfrom
refactor-auto

Conversation

@ArgoZhang

Copy link
Copy Markdown
Member

Link issues

fixes #35

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Copilot AI review requested due to automatic review settings September 24, 2025 06:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request redesigns the AutoReceive function in the TCP socket client implementation. The main changes focus on simplifying the connection process and improving the auto-receive functionality behavior.

  • Removes timeout-related configuration options (ConnectTimeout, SendTimeout, ReceiveTimeout) from TcpSocketClientOptions
  • Refactors the AutoReceive functionality to use proper await instead of fire-and-forget Task.Run
  • Consolidates and reorganizes receive-related unit tests

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TcpSocketClientOptions.cs Removes timeout configuration properties
DefaultTcpSocketClient.cs Refactors AutoReceive method and adds validation for ReceiveAsync when auto-receive is enabled
TcpSocketClientOptionsExtensions.cs Updates Clone method to exclude removed timeout properties
ITcpSocketClientExtensions.cs Adds null check before buffer copy in ReceiveAsync extension
TcpSocketFactoryTest.cs Consolidates test methods and removes timeout-related test configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/Longbow.TcpSocket/Interface/DefaultTcpSocketClient.cs Outdated
Comment thread src/Longbow.TcpSocket/Interface/DefaultTcpSocketClient.cs
@ArgoZhang ArgoZhang merged commit 602f3cc into master Sep 24, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the refactor-auto branch September 24, 2025 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: redesign AutoReceive function

2 participants