This repository was archived by the owner on Nov 13, 2025. It is now read-only.
chore: use trusted publishing action#40
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements trusted publishing for NuGet package deployment by replacing API key authentication with OpenID Connect (OIDC) token-based authentication. This approach enhances security by eliminating the need to store long-lived API keys as secrets.
- Adds OIDC permissions for token-based authentication
- Introduces NuGet login action to obtain temporary API keys
- Updates environment variable source from stored secret to login action output
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+28
to
+29
| with: | ||
| user: ${{ secrets.NUGET_USER }} |
There was a problem hiding this comment.
Using secrets.NUGET_USER contradicts the purpose of trusted publishing, which is designed to eliminate the need for stored secrets. Trusted publishing should work without any user credentials or API keys stored as secrets.
Suggested change
| with: | |
| user: ${{ secrets.NUGET_USER }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #39
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge