feat(rich-text-input): add secondary tag selector#5037
Draft
obraud wants to merge 5 commits into
Draft
Conversation
obraud
commented
Jun 17, 2026
obraud
commented
Jun 17, 2026
Comment on lines
+159
to
+164
| #normalize(str: string): string { | ||
| return str | ||
| .normalize('NFD') | ||
| .replace(/\p{Diacritic}/gu, '') | ||
| .toLowerCase(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Do we have a common utility file for this kind of code? @Supamiu
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5037/index.html |
obraud
force-pushed
the
feat/rte-secondary-selector
branch
from
36f87f6 to
f886ed8
Compare
obraud
force-pushed
the
feat/rte-secondary-selector
branch
from
f886ed8 to
e6cdd80
Compare
obraud
commented
Jun 29, 2026
| untracked(() => { | ||
| ref.enableFilterPillMode(); | ||
| ref.registerFilterPillClosePopover(this.closePopover); | ||
| ref.registerFilterPillUpdatePosition?.(this.updatePosition); |
Contributor
Author
There was a problem hiding this comment.
I guess the select panel is not exported by LF & cannot be used separately from select component? My concern with is that we register the callback but never unregister. Depending on internal implementation, that could lead to memory leaks & event handler duplications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add secondary tag selector