fix(ci): enable C++ server unit tests in CI#384
Merged
davide221 merged 1 commit intoJun 15, 2026
Conversation
test_server_unit (204 tests covering SSE emitter, tool parser, reasoning parser, sampler, prefix cache, chat templates) was defined in CMakeLists.txt and registered with ctest but never built or run in CI. The comment claiming 'requires libcurl-dev' was incorrect — all curl code is #ifdef-guarded and the binary compiles fine without it. Add test_server_unit to the build targets and uncomment the ctest step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
test_server_unitis defined inserver/CMakeLists.txt:874-902and registered with ctest (line 901), but is never built or run in CI. The commented-out ctest block at.github/workflows/ci.yml:63-67claims:This is incorrect. All curl usage in
http_server.cppis behind#ifdef DFLASH_HAS_CURL(lines 14, 60-254, 809, 954, 2187-2236). CMakeLists.txt conditionally definesDFLASH_HAS_CURLonly whenCURL_FOUND(lines 888-893). The test binary compiles and runs fine without curl — the proxy passthrough feature is simply disabled.Bug
204 CPU-only tests covering critical server components are untested in CI:
Fix
test_server_unitto the cmake build targets (line 60)Changes
.github/workflows/ci.yml— addedtest_server_unitto build targets, uncommented ctest stepVerification
http_server.cppis#ifdef DFLASH_HAS_CURLguarded (5 occurrences)CMakeLists.txtconditionally defines and links curl only whenCURL_FOUNDJimver/cuda-toolkit@v0.2.35Notes
dflash_commonwhich includes ggml-cuda, but CI has CUDA installed so this is fine