Remove Author Column from guidelist and add search box#3303
Open
Spoony36 wants to merge 2 commits intoLudovicus-Maior:mainfrom
Open
Remove Author Column from guidelist and add search box#3303Spoony36 wants to merge 2 commits intoLudovicus-Maior:mainfrom
Spoony36 wants to merge 2 commits intoLudovicus-Maior:mainfrom
Conversation
Owner
|
OOOOOOh! |
WoWPro/WoWPro_GuideList.lua
Outdated
| or GuideFieldMatches(guide.Name, filterText) | ||
| or GuideFieldMatches(guide.Zone, filterText) | ||
| or GuideFieldMatches(guide.Content, filterText) | ||
| or GuideFieldMatches(guide.Author, filterText) |
Owner
There was a problem hiding this comment.
If Author is not displayed, why search on it?
Collaborator
Author
There was a problem hiding this comment.
Opps, i wasn't intending to remove the author column when i added the search function :D
Ludovicus-Maior
requested changes
Apr 3, 2026
| local guides = self.guides | ||
| local buttons = _G.HybridScrollFrame_GetButtons(self) | ||
| local offset = _G.HybridScrollFrame_GetOffset(self) | ||
| local headerCount = self.activeHeaderCount or #self.headers |
Owner
There was a problem hiding this comment.
Will Author be on the header list and thus the count off by one?
Collaborator
Author
There was a problem hiding this comment.
It shouldn't be but have simplified the search function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested a while back