Fix zone auto-complete bug during guide load#3308
Draft
Hendo72 wants to merge 2 commits intoLudovicus-Maior:mainfrom
Draft
Fix zone auto-complete bug during guide load#3308Hendo72 wants to merge 2 commits intoLudovicus-Maior:mainfrom
Hendo72 wants to merge 2 commits intoLudovicus-Maior:mainfrom
Conversation
- changed the ZONE_CHANGED handler so WoWPro:UpdateGuide(event) is only called when WoWPro.AutoCompleteZone() returns true. - This avoids unnecessary guide refreshes on zone changes when no zone-based step auto-completion occurred. - Keeps event handling more efficient and limits updates to actual state changes.
Bug: - Zone-based step completion during guide load leaves stale active guide state Fix load-time zone auto-complete so guide refreshes after zone-based completion, with bounded retry and fallback reload if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the bug is
In short: AutoCompleteZone() completed a F/H/b/P/R step during setup, but the guide load process did not re-synchronize the guide state and the completed step would still appear active in the guide window.
TL;DR
What changed in WoWPro_Parser.lua
Added a bounded retry loop around WoWPro.AutoCompleteZone() inside SetupGuideReal().
repeatedly calls WoWPro.AutoCompleteZone() while it keeps completing steps
What changed in WoWPro_Events.lua
Why this fixes it
** each file change was done in its own commit for clarity.