Deployment#757
Merged
Merged
Conversation
Enhancement/interactable banners
Changes to pull request template
...instead of machine type. The rest of the code was working with the assumption that the URL path's `<int:pk>` segment should be the PK of a machine type, like https://github.com/MAKENTNU/web/blob/2024-05-10/src/make_queue/static/make_queue/js/calendar.js#L393
…based-on-machine Fix incorrect and failing reservation rule lists
* Added CoursePermission and CourseType * Implemented cource permission class * migrated data * Updated views and admin to use new permission * fixed bug with auth requirement * added coursepermission to admin * Updated course page * Updated form ui for courses * Made 3dpr permission automatic * updated url tests * update machine tests * updated reservation test * updated machine and reservation tests * code cleanup * Added translations * Fixed api bug * Removed print * fixed line endings hopefully * Fixed naming in migrations * Fixed usage hint and translation typo * fixed some codeclimate cleanup * removed some whitespace * Added changes to unreleased in changelog * Made some fixes according to review comments * Removed unused if statement * Added if statement to prevent when a user has no registered course * updated more code according to feedback * removed whitespace * i removed one too many whitespace lines, whoops * fixed bug where course list used old get_permission_names method * removed atomic flag * merged migrations * Switched to using enum instead of "3DPR" and similar strings --------- Co-authored-by: Anders <6058745+ddabble@users.noreply.github.com> Co-authored-by: Sigrid <55406589+sigtheidiot@users.noreply.github.com> Co-authored-by: Gunvor4 <114504373+Gunvor4@users.noreply.github.com>
make-bot
Bot
added
the
deployment
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 88.17% 88.28% +0.11%
==========================================
Files 152 152
Lines 6198 6207 +9
==========================================
+ Hits 5465 5480 +15
+ Misses 733 727 -6
🚀 New features to boost your workflow:
|
elisakiv
approved these changes
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
devbranch has been deployed to makentnu.dev and can be manually tested there before merging.Brings in the changes from the following PRs: