Skip to content

Sort properties by their change interval in the state list #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BramOtte wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sort properties by their change interval in the state list #241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5373a0
Sort properties by their change interval in the state list
BramOtte May 3, 2026
77a9aa8
cargo fmt
BramOtte May 3, 2026
ea472e5
Give more sensible variable name
BramOtte May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions crates/block_data_gen/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,23 @@ fn process_block(
),
};
}

// Sort properties by their change interval in the state list in ascending order.
props.sort_by_cached_key(|prop| {
let name = prop.name.as_str();

let previous_state =
json.states.first().unwrap().properties.as_ref().unwrap()[name].as_str();

let interval = json
.states
.iter()
.position(|state| state.properties.as_ref().unwrap()[name] != previous_state)
.unwrap();

usize::MAX - interval
});

let mut attrs = BlockAttrs::default();
for attr in attrs_str.split(',').filter(|s| !s.is_empty()) {
match attr {
Expand Down
Loading