Replace MSVC __debugbreak with cross-compiler DEBUG_BREAK macro.#1540
Open
ModMaker101 wants to merge 2 commits intoMCLCE:mainfrom
Open
Replace MSVC __debugbreak with cross-compiler DEBUG_BREAK macro.#1540ModMaker101 wants to merge 2 commits intoMCLCE:mainfrom
ModMaker101 wants to merge 2 commits intoMCLCE:mainfrom
Conversation
Contributor
|
Plz pull in the PR workflow fix so your pr can build |
Contributor
Author
|
@codeHusky Just pulled in the fix. The PR should build now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace MSVC-specific
__debugbreak()withDEBUG_BREAK()macro.Changes
Previous Behavior
__debugbreak()was in the code.Root Cause
Platform-specific intrinsic used.
New Behavior
DEBUG_BREAK()compiles on MSVC, GCC, and Clang with a fallback.Fix Implementation
Created a Debug.h with a macro; with a
DEBUG_BREAK()macro.AI Use Disclosure
No.
Related Issues