Remove HTML escape for apostrophe in chat #1537#1541
Merged
codeHusky merged 1 commit intoMCLCE:mainfrom Apr 26, 2026
Merged
Conversation
Contributor
|
thanks for this, i was meant to get around to it but forgot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed HTML escaping for apostrophe chars in chat.
Changes
Previous Behavior
Chat messages containing
'were being converted to the HTML version of', which displayed it literally in chat instead of showing an apostrophe.Root Cause
The
EscapeHTMLStringwas incorrectly escaping single quotes. Single quotes do NOT need to be escaped in HTML.New Behavior
Chat messages now show the apostrophes normally.
Fix Implementation
Removed
{L'\''...}from thereplacementMapin theEscapeHTMLString.AI Use Disclosure
No AI used.
Related Issues
Oh, and I think ReSharper auto formatted the
replacementMapso that's why Git is freaking out.