Feat/custom recipes#1542
Open
DrPerkyLegit wants to merge 10 commits intoMCLCE:mainfrom
Open
Conversation
Contributor
Author
|
i have tested this and it looks to be working perfectly but i would prefer someone else to test this out a bit before it gets accepted, we sync normal recipes so if you have issues with a default crafting recipe its caused by the syncing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adding a packet for the server to sync recipes it has with the client
Changes
Previous Behavior
before this the client and server just assumed they had the correct recipe list, now its synced to ensure proper crafting
Root Cause
client and server were always the same, tight protocol versions ensured this was never needed on consoles
New Behavior
now the client gets a list of recipes from the server
Fix Implementation
during the PreLoginPacket the client sets a dirty recipe state thats waiting for the recipe packet, its expecting the packet before the final LoginPacket from the server, the server then sends a CustomPayloadPacket with encoded recipe data making the client no longer wait for recipes and continue, if the server doesnt send the recipe data before the final LoginPacket then it will rebuild recipes from the clients list of known recipes
AI Use Disclosure
no
Related Issues