Fix autosave thread compression TLS crash.#1544
Open
ModMaker101 wants to merge 1 commit intoMCLCE:mainfrom
Open
Fix autosave thread compression TLS crash.#1544ModMaker101 wants to merge 1 commit intoMCLCE:mainfrom
ModMaker101 wants to merge 1 commit intoMCLCE:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash in
ConsoleSaveFileOriginal::Flushwhen autosavfe runs on a worker thread with uninitialized Compression TLS.Changes
Previous Behavior
Server crashes with a read access violation.
tlspointer isnullptrinCompression::getCompressionbecause the thread storage slot was never initialized on the save worker thread.Root Cause
std::threadat ConsoleSaveFileOriginal callsCompression::getCompressionwithout first initializing TLS.New Behavior
Autosave completes without crashing. Worker thread now properly sets up TLS before calls.
Fix Implementation
Added
Compression::UseDefaultThreadStorageat the start of the lambda before any compression calls.AI Use Disclosure
None.
Related Issues
Side-note
This only happened in Debug mode to my knowledge. I was just getting annoyed with it crashing on me.