doc: Add missing contributors for v2.10.0 (closes #5136)#5139
doc: Add missing contributors for v2.10.0 (closes #5136)#5139Aryaman-Chaudhri wants to merge 3 commits intoMDAnalysis:developfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
| - Matthew Davies | ||
| - Jia-Xin Zhu | ||
| - Tanish Yelgoe | ||
| Here is the updated list for you to copy and paste into the `! AUTHORS` file. I have added `Pradyumn-cloud` to the end of the 2025 list. |
There was a problem hiding this comment.
Is this a leftover comment from an LLM / AI coding tool?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5139 +/- ##
===========================================
- Coverage 93.83% 93.82% -0.01%
===========================================
Files 180 180
Lines 22475 22473 -2
Branches 3190 3189 -1
===========================================
- Hits 21090 21086 -4
- Misses 923 924 +1
- Partials 462 463 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
- Please remove the odd comment in the authors file.
- Did you check that there were no other authors missing? The list in the original issue was not an exhaustive list but rather just "those that I came across".
|
Hi Irfan, thanks for the review! I've removed the stray comment and pushed the fix. I also went through all the PRs listed in the 2.10.0 changelog and checked their authors against the contributor list. It looks like the 5 authors from the issue were the only ones missing. I believe the list is complete now. Thanks again! |
Aryaman-Chaudhri
force-pushed
the
fix-authors-5136
branch
from
804c27d to
30e29b1
Compare
|
Hi @BradyAJohnston , I have done the necessary by adding contributor names to both author and changelog. Sdist has been failing but i dont think it is because some change i made since this is a documenation task . please help and comment. |
|
Hi @BradyAJohnston , @IAlibay , I believe this is ready for review as earlier issues have been resolved. |
| yuxuanzhuang, yuyuan871111, tanishy7777, tulga-rdn, Gareth-elliott, | ||
| hmacdope, tylerjereddy, cbouy, talagayev, DrDomenicoMarson, amruthesht, | ||
| p-j-smith, gitzhangch, raulloiscuns | ||
| p-j-smith, gitzhangch, raulloiscuns, lexi-x, namiroues, jpkrowe, schuhmc, gitsirsha, Pradyumn-cloud |
There was a problem hiding this comment.
As per line 10, please keep this to 79 characters, if a name goes beyond that, wrap it around to the next line.
3 participants
Fixes #5136
Changes made in this Pull Request:
CHANGELOGfile.! AUTHORSfile.PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE is my own original work.
📚 Documentation preview 📚: https://mdanalysis--5139.org.readthedocs.build/en/5139/