Fix: Stop TDI execution from editing caller's Python namespace - #3082
Open
benjysmith wants to merge 5 commits into
Open
Fix: Stop TDI execution from editing caller's Python namespace#3082benjysmith wants to merge 5 commits into
benjysmith wants to merge 5 commits into
Conversation
benjysmith
marked this pull request as ready for review
August 11, 2026 22:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3081, where the observed symptom was
__file__being changed permanently to the path of the TDI function being executed.The issue stems from using
__main__as a scratch pad to store the reference to the function being called, the__file__variable, etc. The fix implemented here is to give each TDI function its own namespace to use:tdi_functions.<function name>instead of__main__. This also requires changing theSimplePyFuncalls into normal ones as theSimpleones use the global namespace, and changingget_exec_fileto use a provided namespace, rather than just__main__.__dict__.This prevents the function's namespace from colliding with the caller, and also prevents potential collisions between different Python-implemented TDI functions.
Additionally, a test case for this was written, which checks that
__file__is modified when viewed from inside the TDI function, but not modified in the caller's namespace.