-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(podcasts): short default brief length with seconds and unit picker #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CREDO23
merged 16 commits into
MODSetter:main
from
CREDO23:feat/podcast-brief-duration-seconds
Jun 16, 2026
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9583e8f
feat(podcasts): add shared duration limit constants
CREDO23 32e0d21
feat(podcasts): store brief duration in seconds with legacy load
CREDO23 085442e
feat(podcasts): use seconds defaults on create podcast request
CREDO23 845653c
feat(podcasts): pass min_seconds and max_seconds when proposing brief
CREDO23 d0ed5b9
refactor(podcasts): use shared second-based brief duration defaults
CREDO23 af08e2f
refactor(podcasts): propose brief with min_seconds and max_seconds
CREDO23 116c38f
refactor(podcasts): build DurationTarget from brief seconds config
CREDO23 16d226e
refactor(podcasts): plan transcript length from midpoint seconds
CREDO23 608620d
feat(web): add seconds-based podcast duration types with legacy support
CREDO23 bab3f7c
feat(web): add unit dropdown for podcast brief target length
CREDO23 38991c7
test(podcasts): update integration fixtures for second-based duration
CREDO23 cb70b64
test(podcasts): update unit fixtures for second-based duration
CREDO23 f997b64
test(podcasts): update renderer test for second-based duration
CREDO23 fd96c93
test(podcasts): cover seconds duration and legacy minute specs
CREDO23 7a415b6
test: align QuotaInsufficientError fixtures with balance_micros API
CREDO23 7584312
style(podcasts): fix ruff issues in podcast spec schema
CREDO23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| """Shared bounds and defaults for podcast target duration.""" | ||
|
|
||
| MAX_DURATION_SECONDS = 24 * 60 * 60 | ||
| MIN_DURATION_SECONDS = 15 | ||
| DEFAULT_MIN_SECONDS = 20 | ||
| DEFAULT_MAX_SECONDS = 30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: MODSetter/SurfSense
Length of output: 922
🏁 Script executed:
Repository: MODSetter/SurfSense
Length of output: 2683
🏁 Script executed:
Repository: MODSetter/SurfSense
Length of output: 2097
Enforce duration ordering in
CreatePodcastRequest.min_secondsandmax_secondsare validated independently, so inverted ranges pass request validation and fail later whenDurationTargetis instantiated insurfsense_backend/app/podcasts/generation/brief/nodes.py(line 82) with a 500 error. Reject this at the API boundary with a 422 validation error instead.Suggested fix
🤖 Prompt for AI Agents