Conversation
…e tab reset logic on search space change
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on f263cf9..e47c786
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (2)
• surfsense_web/atoms/tabs/tabs.atom.ts
• surfsense_web/components/layout/providers/LayoutDataProvider.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e tab reset logic on search space change
Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR implements session storage persistence for tabs state management using Jotai's
atomWithStorageutility, allowing tabs to survive page refreshes. It also optimizes the tab reset logic to prevent unnecessary resets on component mount by using a ref to track when the search space ID actually changes, ensuring tabs are only reset when users switch between different search spaces rather than on every render.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/atoms/tabs/tabs.atom.tssurfsense_web/components/layout/providers/LayoutDataProvider.tsx