fix: add focus-visible styles to share button for improved accessibility#999
Merged
MODSetter merged 1 commit intoMar 27, 2026
Merged
Conversation
|
@JoeMakuta is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on c7ace83..0b4ba58
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/components/new-chat/chat-share-button.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've updated the share dialog's visibility option buttons to include a proper focus-visible ring indicator. The buttons now have:
focus-visible:ring-2- A 2-pixel ring that appears when focused via keyboardfocus-visible:ring-ring- Uses the project's standard ring color from shadcnfocus-visible:ring-offset-2- Adds proper spacing between the ring and elementMotivation and Context
FIX #915
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This PR improves keyboard navigation accessibility by adding focus-visible ring indicators to the share dialog's visibility option buttons. The change adds three Tailwind CSS classes (
focus-visible:ring-2,focus-visible:ring-ring, andfocus-visible:ring-offset-2) to two button elements, ensuring proper visual feedback when users navigate using keyboard controls.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/components/new-chat/chat-share-button.tsx