Fix nondeterministic behavior in NMS#143
Open
Kaminyou wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for posting this fix, I'll try to reproduce the issue and check the fix this week and then merge it if all is working on our end too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using two or more identical reference points, the number of picked particles could vary across runs. For example:
This inconsistency was caused by uninitialized memory in the NMS implementation:
np.empty()creates an uninitialized array whose contents are random values left over in memory.If any of those uninitialized elements happen to be 1, they will be interpreted as True after
iou_mask = iou_mask == 1, causing over-suppression of unrelated boxes and thus nondeterministic results.Reproducibility
To confirm this behavior, you can insert the following lines to inspect the uninitialized array:
Running this snippet often prints nonzero counts, demonstrating that
np.emptymay contain random 1s even before any assignment.Fixed Implementation
This ensures all non-neighbor elements start as False, removing random suppression and guaranteeing deterministic, consistent NMS results across runs.
The output should be always the same.