[BO - Performance] Liste des signalement et export (ajout nom des docs et photos)#5710
Open
[BO - Performance] Liste des signalement et export (ajout nom des docs et photos)#5710
Conversation
|
numew
changed the title
numew
changed the title
numew
requested review from
emilschn,
hmeneuvrier and
sfinx13
and removed request for
sfinx13
emilschn
reviewed
Apr 15, 2026
| s.geoloc') | ||
| ->andWhere("JSON_EXTRACT(s.geoloc,'$.lat') != ''") | ||
| ->andWhere("JSON_EXTRACT(s.geoloc,'$.lng') != ''") | ||
| ->andWhere('s.statut NOT IN (:signalement_status_list)') |
Collaborator
There was a problem hiding this comment.
tu enlèves ça parce que ça faisait doublon avec QueryBuilderFactory, c'est ça ?
emilschn
reviewed
Apr 15, 2026
| ) | ||
| $columns = SignalementExportSelectableColumns::getColumns(); | ||
| $specificSelectKeys = array_keys(array_filter($columns, static fn ($col) => isset($col['specificSelect']))); | ||
| $handledSeparately = array_merge($specificSelectKeys, ['EPCI_NOM', 'STATUT']); |
Collaborator
There was a problem hiding this comment.
pourquoi ces colonnes ne sont pas en specificSelect, du coup ?
emilschn
reviewed
Apr 15, 2026
| @@ -449,7 +457,6 @@ public function applyFilters(QueryBuilder $qb, array $filters, User $user): Quer | |||
| } | |||
|
|
|||
| if (!empty($filters['isImported'])) { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
#5701
Description
Réécriture du système de requétage des signalement utilisé sur
Résultats
Principe d'optimisation
countéviter d'embarquer des champs de table en left join)Changements apportés
scoreetisNotOccupantdeSignalementAffectationListView.photosetdocumentssurSignalementExportFactory.findSignalementAffectationListpour un requétage en deux passe afin d'améliorer les performances sur la page liste des signalements. En parallèle modification deQueryBuilderFactorypour les même raison. Quelque modifications surSearchFiltersite à cela.ExportIterableQuerypour un requétage en deux passe (avec récupération des données par lot de 500) pour améliorer les performance de l'export et rendre possible l'export des colonnedocumentsetphotossur de gros volumes. En parallèle modification deSignalementExportLoaderpour les mêmes raison.MapGeoDataQuerypour récupérer uniquement les données nécessaire à la carto.Pré-requis
se mettre sur une copie de prod
Tests