Conversation
sfinx13
force-pushed
the
feature/5715-5714-esabora-schs-feedback
branch
from
b80e740 to
526761d
Compare
|
sfinx13
commented
Apr 15, 2026
Comment on lines
+246
to
+253
| $message = \sprintf( | ||
| '[%s][%s] Suppression du partenaire %s sur le dossier synchronisé #%s', | ||
| $affectation->getSignalement()->getTerritory()->getZipAndName(), | ||
| $affectation->getPartner()->getType()->value, | ||
| $affectation->getPartner()->getId(), | ||
| $affectation->getSignalement()->getReference() | ||
| ); | ||
| \Sentry\captureMessage($message); |
Collaborator
Author
There was a problem hiding this comment.
Prévenir sur le channel dev si le cas se présente
Comment on lines
+42
to
+44
| if (!$isSuccessful) { | ||
| break; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Meilleure gestion des erreurs, pas utile d'appeler les web-services suivants si un des web-services est en erreur, ça va moins polluer la table.
|
|
||
| abstract class AbstractDossierSISHHandler implements DossierSISHHandlerInterface | ||
| { | ||
| public const string ERROR_SQL_DUPLICATE_KEY = 'WS_ERR_SQL'; |
Collaborator
Author
There was a problem hiding this comment.
Vu dans la spec 1.10
| return AbstractEsaboraService::ACTION_PUSH_DOSSIER_PERSONNE === $this->action | ||
| && JobEvent::STATUS_SUCCESS === $this->status; | ||
| && JobEvent::STATUS_SUCCESS === $this->status | ||
| || $this->dossierAlreadyExists(); |
| parent::handle($dossierMessageSISH); | ||
| } | ||
|
|
||
| return true; // last SISH web service called; no need to handle further |
Collaborator
Author
There was a problem hiding this comment.
Rappel de l'ordre d'appel :
- SISH_ADRESSE
- SISH_DOSSIER
- SISH_DOSSIER_PERSONNE
Comment on lines
+44
to
+50
| $partnerType = match ($doneBy) { | ||
| 'SCHS' => PartnerType::COMMUNE_SCHS, | ||
| 'ARS' => PartnerType::ARS, | ||
| default => PartnerType::tryFrom($doneBy), | ||
| }; | ||
|
|
||
| if (null !== $partnerType && $affectation->getPartner()->getType() === $partnerType) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
#5715
#5714
Description
Changements apportés
Pré-requis
make mock-restartmake worker-stop && make worker-consumeTests
Message de confirmation
Resynchronisation
- Vérifier que le mock a bien renvoyé un code erreur de doublon sur le premier appel http://localhost:8080/bo/connexions-si/
- Vérifier que les autres appels ne sont pas effectué
- Vérifier que l'affectation est bien taggé comme synchronisé en base
Synchronisation des visites
make sync-sishet vérifier que le partenaire d'affectation n'est pas repris dans le message de suivi mais plutôt le partenaire fourni par le web-service car différent