fix: resolve clippy warnings in BFV implementation and tests#140
Draft
fix: resolve clippy warnings in BFV implementation and tests#140
Conversation
Fixed unnecessary casts, needless borrows, and unused variable warnings: - Changed `1 as u8` to more idiomatic `1_u8` in FinRingElem creation - Removed needless borrows for params_q in decompose_base calls - Prefixed unused variables with underscore to silence warnings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed clippy warnings throughout the codebase to improve code quality and eliminate compiler warnings. The changes address unnecessary casts, needless borrows, and unused variable warnings.
Changes include removing unnecessary
as u8casts in favor of more idiomatic1_u8literals, eliminating needless reference operations in function calls, and properly marking unused variables with underscore prefixes.All changes maintain existing functionality while following Rust best practices and clippy recommendations.
🤖 Generated with Claude Code