Skip to content

review logger factory code part: use switch/case #3812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rejas merged 3 commits into from
Jun 20, 2025
Merged

review logger factory code part: use switch/case #3812

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cf58fe
review logger factory code part: use switch/case
bugsounet Jun 20, 2025
aa6199f
add PR number
bugsounet Jun 20, 2025
3dbf69e
Merge branch 'develop' into logger
rejas Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ planned for 2025-07-01
### Updated

- [core] Update dependencies including electron to v36 (#3774, #3788, #3811)
- [logger] Review factory code part: use `switch/case` instead of `if/else if` (#3812)

## [2.31.0] - 2025-04-01

Expand Down
37 changes: 23 additions & 14 deletions js/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,35 @@
label: (arg) => {
const { method, defaultTokens } = arg;
let label = defaultTokens.label(arg);
if (method === "error") {
label = styleText("red", label);
} else if (method === "warn") {
label = styleText("yellow", label);
} else if (method === "debug") {
label = styleText("bgBlue", label);
} else if (method === "info") {
label = styleText("blue", label);
switch (method) {
case "error":
label = styleText("red", label);
break;
case "warn":
label = styleText("yellow", label);
break;
case "debug":
label = styleText("bgBlue", label);
break;
case "info":
label = styleText("blue", label);
break;
}
return label;
},
msg: (arg) => {
const { method, defaultTokens } = arg;
let msg = defaultTokens.msg(arg);
if (method === "error") {
msg = styleText("red", msg);
} else if (method === "warn") {
msg = styleText("yellow", msg);
} else if (method === "info") {
msg = styleText("blue", msg);
switch (method) {
case "error":
msg = styleText("red", msg);
break;
case "warn":
msg = styleText("yellow", msg);
break;
case "info":
msg = styleText("blue", msg);
break;
}
return msg;
}
Expand Down