Fix calendar js timestamp conversion#3832
Closed
plebcity wants to merge 1 commit intoMagicMirrorOrg:developfrom
Closed
Fix calendar js timestamp conversion#3832plebcity wants to merge 1 commit intoMagicMirrorOrg:developfrom
plebcity wants to merge 1 commit intoMagicMirrorOrg:developfrom
Conversation
…nt and fixed the broken unit test
4 tasks
Contributor
Author
Contributor
Author
|
Ah wait a second, my local files haven't all updated yet. I will check if this fix is actually needed in calendar.js. Otherwise I will remove that fix and just fix the unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the calendar.js method where the local timezone unix timestamp is converted to a moment. And it also fixes the broken unittest on 01-01 and 01-07.