fix(updatenotification): harden git command execution + simplify checkUpdates#4115
Draft
KristjanESPERANTO wants to merge 2 commits intoMagicMirrorOrg:developfrom
Draft
fix(updatenotification): harden git command execution + simplify checkUpdates#4115KristjanESPERANTO wants to merge 2 commits intoMagicMirrorOrg:developfrom
KristjanESPERANTO wants to merge 2 commits intoMagicMirrorOrg:developfrom
Conversation
Use execFile with cwd and variadic git arguments to avoid shell interpretation of repository paths and resolve CodeQL alert #16. Update unit tests to cover the refactored execGit API.
Remove the unnecessary async Promise wrapper in checkUpdates and use a direct loop over collected repository info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes CodeQL alert #16 by replacing shell-built git commands with
execFile+cwdin updatenotification’sgit_helper.It also includes a small cleanup in
checkUpdates()(remove unnecessary async/Promise wrapper) and updates the related unit tests.