fix(router-core): map RouteExpired to distinct ResolveError variant in batch_resolve - #856
Merged
Maki-Zeninn merged 3 commits intoJul 25, 2026
Conversation
set_route_fee_tiers accepted FeeTier structs with negative min_amount values, producing nonsensical tiered fee logic (negative thresholds can never match a valid amount_in). Add an early validation that returns QuoteError::InvalidFeeTier (new variant = 9) if any tier's min_amount is less than zero. Closes Maki-Zeninn#801
…n batch_resolve Add RouteExpired to the ResolveError enum and add an explicit match arm in batch_resolve so expired-route errors are no longer silently folded into the generic RouteNotFound catch-all, giving callers a distinct signal to distinguish expiry from absence. Closes Maki-Zeninn#708
|
@Devcyprian Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RouteExpiredvariant to theResolveErrorenum so callers can distinguish an expired route from a missing routeErr(RouterError::RouteExpired) => BatchResolveResult::Err(ResolveError::RouteExpired)arm inbatch_resolvebefore the generic catch-allRouteExpiredsilently fell intoErr(_) => BatchResolveResult::Err(ResolveError::RouteNotFound), losing error identityCloses #708