docs(sdk): add code fences; test(api-server): malformed JSON /simulate body - #936
Merged
Maki-Zeninn merged 1 commit intoJul 27, 2026
Conversation
… JSON /simulate body - Wrap the Installation, Quick Start, and Publishing snippets in docs/sdk.md with proper markdown code fences, matching the style used elsewhere in docs/. - Add test_simulate_malformed_json_body_returns_400_or_422 to exercise axum's Json extractor rejection path (non-JSON body) on POST /simulate, distinct from the existing empty-object test which only hits handler validation. Closes Maki-Zeninn#920 Closes Maki-Zeninn#918 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@frienzy514-png Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/sdk.md, matching the style used in the rest ofdocs/(e.g.docs/signing-abstraction.md).test_simulate_malformed_json_body_returns_400_or_422inapi-server/src/tests.rs, which sends a non-JSON body ("not json") toPOST /simulateto exercise axum'sJsonextractor rejection path, complementing the existingtest_simulate_empty_body_returns_400_or_422test which only covers syntactically-valid-but-empty JSON.Closes #920
Closes #918
Test plan
docs/sdk.mdfor correct fencing/formattingcargo test -p api-server test_simulate_malformed_json_body_returns_400_or_422(could not run locally — no Rust toolchain in this environment; please verify in CI)🤖 Generated with Claude Code