test(router-execution): add simulate() success path coverage (Closes #956) - #980
Merged
Merged
Conversation
Add test_simulate_success_path to exercise the success branch of simulate() where try_invoke_contract returns Ok(_). The test verifies: - result.success == true - result.would_fail == false - result.message == "simulation succeeded" - simulation_result event is emitted with success=true Reuses the existing MockTarget contract (already registered for execute() success path tests) and calls client.simulate() against its ping() function with empty args. Closes Maki-Zeninn#956
|
@believetimothy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
test_simulate_success_pathto exercise the success branch ofsimulate()wheretry_invoke_contractreturnsOk(_).Problem
Existing simulate tests (
test_simulate_nonexistent_contract_fails,test_simulate_returns_message_on_failure) only exercise the failure branch, where the target is an address with no deployed contract. The success branch (sim_ok == true,message == "simulation succeeded") is never tested.A regression that flips or breaks the success-path message, or the
success/would_failflags, would go undetected.Changes
test_simulate_success_pathincontracts/router-execution/src/lib.rs— reuses the existingMockTargetcontract (already defined for theexecute()success path tests) and callsclient.simulate()against itsping()function with empty args.Assertions
result.success == trueresult.would_fail == falseresult.message == "simulation succeeded"simulation_resultevent is emitted withsuccess=trueTesting
cargo test test_simulate_success_pathCloses #956