Skip to content

Fix image rendering#3

Open
nikhil1raghav wants to merge 2 commits into
config-in-folderfrom
fix-image-rendering
Open

Fix image rendering#3
nikhil1raghav wants to merge 2 commits into
config-in-folderfrom
fix-image-rendering

Conversation

@nikhil1raghav

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread util/murmurhash.go
return hashStr

//TODO: this works but is functionally incorrect, assign mimetype based on content
return fmt.Sprintf("img%s.png",hashStr)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

Comment thread mail/mailer.go
fmt.Println("Dialer timeout ", dialer.Timeout)

util.CyanBold.Println("Sending mail")
util.Cyan.Println("Mail timeout : ", dialer.Timeout.String())

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

@watermelon-copilot-for-code-review

Copy link
Copy Markdown

WatermelonAI Summary

This PR addresses the issue of images not rendering on Kindle devices. It also includes a dry run flag and a list of files before sending.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
kindle-send is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant