Closed
Conversation
mschwoer
force-pushed
the
add_timstof_2
branch
2 times, most recently
from
8477efa to
703c9cf
Compare
add some TODOs to resolve remaining timsTOF dependencies Revert "add some TODOs to resolve remaining timsTOF dependencies" This reverts commit 86d5753.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In contrast to #110 , this moved only the basic funcionality of the TimsTOF class (keeping e.g. the slicing in alphatims).
This would requite the following upfront changes to resolve the remaining dependencies on the TimsTOF class: #112
Code was cut-pasted (see commits of the same name here MannLabs/alphatims#309) and then carefully adapted