feat: add nodeId to Dataset, DatasetVersion, and Job API response models#3105
Open
psaikaushik wants to merge 2 commits intoMarquezProject:mainfrom
Open
feat: add nodeId to Dataset, DatasetVersion, and Job API response models#3105psaikaushik wants to merge 2 commits intoMarquezProject:mainfrom
nodeId to Dataset, DatasetVersion, and Job API response models#3105psaikaushik wants to merge 2 commits intoMarquezProject:mainfrom
Conversation
Add computed getNodeId() methods to Dataset, DatasetVersion, and Job service models. This allows API consumers to directly use the nodeId to query the Lineage API without having to manually construct it. - Dataset: returns "dataset:namespace:name" - DatasetVersion: returns "dataset:namespace:name#version" - Job: returns "job:namespace:name" The nodeId is computed from existing fields via NodeId.of(), so no database changes are needed. Closes MarquezProject#1461 Signed-off-by: Sai Kaushik Ponnekanti <psaikaushik@gmail.com>
DbTable's constructor takes 14 parameters. The test was passing 15 by including an extra null for columnLineage, which is handled internally by DbTable when calling super(). Also removed unused import java.net.URL. Signed-off-by: Sai Kaushik Ponnekanti <psaikaushik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a computed
nodeIdfield to theDataset,DatasetVersion, andJobAPI response models. This allows API consumers to directly use thenodeIdto query the Lineage API without having to manually construct it.Supersedes #3102 (recreated to fix DCO sign-off).
Closes #1461
Changes
Dataset.javaAdded
getNodeId()method that returnsNodeId.of(id), producing:DatasetVersion.javaAdded
getNodeId()method that returns a version-qualified nodeId:Job.javaAdded
getNodeId()method that returnsNodeId.of(id), producing:Design Decisions
nodeIdis derived from existing fields viagetNodeId(), so no database changes are needed.NodeIdclass: Leverages the existingNodeId.of()factory methods.Tests
Added
NodeIdOnModelsTest.javawith tests for all three models.Checklist