Skip to content

fix: remove hardcoded JWT signing secrets from .env_rename_me #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saaa99999999 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove hardcoded JWT signing secrets from .env_rename_me #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .env_rename_me
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ DB_PASS="postgres"
DB_NAME="golang_gin_db"
DB_HOST="localhost"
DB_PORT="5432"
ACCESS_SECRET="ashasdjhjhjadhasdaa123"
REFRESH_SECRET="hjsajdhkjhf41jhagggdga"
REDIS_SECRET="hjfhjhasdfkyuy2"
ACCESS_SECRET=
REFRESH_SECRET=
REDIS_SECRET=
REDIS_HOST=127.0.0.1:6379
REDIS_PASSWORD=
12 changes: 12 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,18 @@ func main() {
log.Fatal("error: failed to load the env file")
}

// Validate that security-critical secrets are set
requiredSecrets := map[string]string{
"ACCESS_SECRET": os.Getenv("ACCESS_SECRET"),
"REFRESH_SECRET": os.Getenv("REFRESH_SECRET"),
"REDIS_SECRET": os.Getenv("REDIS_SECRET"),
}
for name, value := range requiredSecrets {
if value == "" {
log.Fatalf("error: %s is not set in the env file — generate a cryptographically random secret", name)
}
}

if os.Getenv("ENV") == "PRODUCTION" {
gin.SetMode(gin.ReleaseMode)
}
Expand Down