Add support for SD-JWT-VC presentations#10
Merged
MasterKale merged 42 commits intomainfrom Apr 18, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for presentation of SD-JWT-VC credentials. Output from
verifyPresentationResponse()now also includes anissuerMetaproperty that includes the following times asDatevalues when available in the information provided by the Issuer:validFrom: The time after which the document can be considered for useexpiresOn: The time after which the document should be considered unusableissuedAt: When the issuer generated the documentA good amount of code cleanup is also included as adding support for this new doc format helped me crystalize some abstractions that were hard to pin down when writing mdoc support.
Presentation using this library was tested against the latest CMWallet. I plan on following this up with tests using OWF's Multipaz next.