sql-parser: fix AstDisplay panic for CREATE TABLE FROM SOURCE with constraints only#36866
Merged
Merged
Conversation
with constraints only
CreateTableFromSourceStatement's AstDisplay entered the
parenthesized block whenever columns were specified OR
constraints were non-empty, but the inner match panicked on
TableFromSourceColumns::NotSpecified. A statement like
CREATE TABLE t (PRIMARY KEY (c)) FROM SOURCE foo (REFERENCE bar)
would crash as soon as the AST was formatted (e.g. via
statement logging). Treat NotSpecified as a no-op and gate the
", " separator so constraints-only output stays valid SQL.
Adds round-trip tests for the constraints-only case and for
columns + constraints (both Defined and Named).
Co-authored-by: Junie <junie@jetbrains.com>
martykulma
approved these changes
Jun 3, 2026
martykulma
left a comment
martykulma
left a comment
Contributor
There was a problem hiding this comment.
thanks @ggevay - lgtm!
antiguru
pushed a commit
that referenced
this pull request
Jun 3, 2026
…h constraints only (#36866) CreateTableFromSourceStatement's AstDisplay entered the parenthesized block whenever columns were specified OR constraints were non-empty, but the inner match panicked on `TableFromSourceColumns::NotSpecified`. A statement like ``` CREATE TABLE t (PRIMARY KEY (c)) FROM SOURCE foo (REFERENCE bar) ``` would crash as soon as the AST was formatted (e.g. via statement logging). Treat `NotSpecified` as a no-op and gate the ", " separator so constraints-only output stays valid SQL. Adds round-trip tests for the constraints-only case and for columns + constraints (both Defined and Named). Co-authored-by: Junie <junie@jetbrains.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateTableFromSourceStatement's AstDisplay entered the parenthesized block whenever columns were specified OR constraints were non-empty, but the inner match panicked on
TableFromSourceColumns::NotSpecified. A statement likewould crash as soon as the AST was formatted (e.g. via statement logging). Treat
NotSpecifiedas a no-op and gate the ", " separator so constraints-only output stays valid SQL. Adds round-trip tests for the constraints-only case and for columns + constraints (both Defined and Named).