Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 519 518 -1
=========================================
- Hits 519 518 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR applies a set of small internal cleanups across the mediator/request/event layers, focusing on removing deprecated references, tightening generic typing, and preventing read operations from mutating internal stores.
Changes:
- Tighten generic typing in request pipeline execution and fix an internal import to avoid deprecated/incorrect library usage.
- Adjust event handler store reads to avoid mutating internal state during lookups.
- Minor comment/doc cleanup and removal of named library directives in public entrypoints.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/request/request_manager.dart | Strengthens typing for the composed pipeline execution delegate. |
| lib/src/request/pipeline/pipeline_configurator.dart | Replaces deprecated/incorrect import with direct type imports needed by the configurator API. |
| lib/src/event/subscription_builder/distinct_builder.dart | Updates comment to match distinct operator behavior (first event is emitted). |
| lib/src/event/handler/event_handler_store.dart | Makes handler lookups non-mutating by avoiding putIfAbsent on read paths. |
| lib/request_manager.dart | Removes named library directive (now uses empty library;). |
| lib/reactive.dart | Removes named library directive (now uses empty library;). |
| lib/mediator.dart | Converts header comment to doc comment and removes named library directive (now uses empty library;). |
| lib/event_manager.dart | Removes named library directive (now uses empty library;). |
| lib/contracts.dart | Removes named library directive (now uses empty library;). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies some small left over improvements: