Skip to content

Small non-breaking improvements#35

Merged
Matthiee merged 6 commits intomasterfrom
feature/small-fixes
Apr 2, 2026
Merged

Small non-breaking improvements#35
Matthiee merged 6 commits intomasterfrom
feature/small-fixes

Conversation

@Matthiee
Copy link
Copy Markdown
Member

@Matthiee Matthiee commented Apr 2, 2026

This PR applies some small left over improvements:

  • Remove deprecated library name
  • Fix dynamic type usage
  • Fix comments
  • Fix import statement
  • Improve read without mutations

@Matthiee Matthiee self-assigned this Apr 2, 2026
@Matthiee Matthiee requested a review from Copilot April 2, 2026 18:52
@Matthiee Matthiee added enhancement New feature or request dart Pull requests that update Dart code labels Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0b5103b) to head (c53a857).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          519       518    -1     
=========================================
- Hits           519       518    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies a set of small internal cleanups across the mediator/request/event layers, focusing on removing deprecated references, tightening generic typing, and preventing read operations from mutating internal stores.

Changes:

  • Tighten generic typing in request pipeline execution and fix an internal import to avoid deprecated/incorrect library usage.
  • Adjust event handler store reads to avoid mutating internal state during lookups.
  • Minor comment/doc cleanup and removal of named library directives in public entrypoints.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
lib/src/request/request_manager.dart Strengthens typing for the composed pipeline execution delegate.
lib/src/request/pipeline/pipeline_configurator.dart Replaces deprecated/incorrect import with direct type imports needed by the configurator API.
lib/src/event/subscription_builder/distinct_builder.dart Updates comment to match distinct operator behavior (first event is emitted).
lib/src/event/handler/event_handler_store.dart Makes handler lookups non-mutating by avoiding putIfAbsent on read paths.
lib/request_manager.dart Removes named library directive (now uses empty library;).
lib/reactive.dart Removes named library directive (now uses empty library;).
lib/mediator.dart Converts header comment to doc comment and removes named library directive (now uses empty library;).
lib/event_manager.dart Removes named library directive (now uses empty library;).
lib/contracts.dart Removes named library directive (now uses empty library;).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Matthiee Matthiee merged commit 3b831b1 into master Apr 2, 2026
14 checks passed
@Matthiee Matthiee deleted the feature/small-fixes branch April 2, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dart Pull requests that update Dart code enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants