🧪 Auto-PR: Merge develop → test - #1013
Merged
Merged
Conversation
…_credentials
Every Keycloak admin call the backend makes authenticates with
grant_type=client_credentials, and Keycloak answers that grant with no
refresh_token. 26.7.0 and 26.7.1 call setRefreshToken(refreshToken)
unconditionally in auth() and decode the result, so decodeToken(undefined) runs
`token.split(".")` and throws
undefined is not an object (evaluating 'token.split')
admin.auth() therefore rejected on EVERY call since the dep sweep in c481d7d:
CORS origin refresh, client-config lookups, every admin route. The SMART
compliance suite has failed on every run since that commit landed — the proxy
could not read inferno-test-client's registered redirect URIs, so /auth/authorize
answered 400 for a redirect_uri that was registered all along.
c481d7d diffed the published .d.ts files and cleared the bump on that basis.
The break is in runtime behaviour with no type change, and every one of our tests
mocks this client, so neither the type diff nor a green suite could see it. That
commit also recorded the deliberate server/client skew (server is 26.6.4); this
restores the lockstep it wanted.
26.7.1 is the newest published version, so there is no forward fix to take.
Adds a contract test that drives the real library against a token endpoint
answering the way Keycloak does, so a future bump reintroducing this fails in the
suite instead of in CI four commits later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Pull Request 🤖
Commits ahead of test: 2
Commits behind test: 0
TODOs remaining in codebase: 3