🧪 Auto-PR: Merge develop → test - #1021
Merged
Merged
Conversation
A link scoped to one imaging study told the recipient Complete summary — the patient shared their full health record while the proxy answered ~27 of the viewer's 30 queries with 403 "outside shared study scope". The viewer drew each denial as its empty state, so the screen read "No known allergies", "No active medications", "No active conditions" for a record nobody was allowed to see. Denied and absent are not the same claim, and this one is the dangerous direction. `complete` was computed inline at the mint site as `!shareScope`, which knew about selective de-selection because that is what it shipped with, and never learned about study scoping — even though study scoping narrows harder (default-deny to this patient, this study, metadata). Extracted to isCompleteShare beside the other scope rules, so the next narrowing dimension has one obvious place to be counted, with tests including the case that regressed. Verified against the live beta link: 27 of 30 queries 403, only Patient, ImagingStudy and metadata pass. The viewer half — dropping cards that have nothing to show, so a denial cannot be read as an assertion — is in patient-portal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Pull Request 🤖
Commits ahead of test: 2
Commits behind test: 0
TODOs remaining in codebase: 3