🧪 Auto-PR: Merge develop → test - #970
Merged
Merged
Conversation
Losing `default-roles-proxy-smart` costs a user `offline_access`, and a user without that role fails the token exchange of any client requesting that scope — after logging in successfully. That is how beta's `admin` account came to fail MCP connection while looking completely healthy on this screen. The admin console could neither show it nor fix it. Technical roles were dropped as soon as they were fetched, then filtered again at the picker, so `default-roles-*`, `offline_access` and `uma_authorization` were invisible and unassignable. They are now fetched and filtered at the picker instead, behind a "Show technical roles" switch that reuses RolesManager's existing pattern rather than inventing a second one. Off by default, so the normal view is unchanged. Any technical role a user already holds is listed even with the switch off, since that is what someone opens this dialog to check. Edit form only. New users get the realm defaults from Keycloak automatically; it is existing users that can lose them.
Cuts eslint from 38 warnings to 8 by fixing all 30 no-console sites rather than suppressing them. src/lib/logger.ts already buffers to a ring, persists to localStorage and mirrors to console only when debug mode is on. These calls bypassed it, so they were both missing from the debug buffer and printing in a production console. They now go through logger.debug/info. logger.ts keeps one eslint-disable: it dispatches all four levels dynamically and is the sanctioned console boundary. Two things surfaced while converting: tokenRefresh.ts called console.debug and logger.info on adjacent lines with the same message. Dropped the console half. authStore.ts guarded six calls with `if (import.meta.env.DEV)`. The logger already gates its console mirror on debug mode, so the guards were redundant — and removing them means those messages reach the buffer in production, where they are worth having. The 8 remaining warnings are left deliberately: 7 react-hooks/ exhaustive-deps and 1 react-refresh. Three of the seven are a missing `t`, but IdPManager and MonitoringDashboard want values added to a useEffect/useMemo whose referential stability has not been checked, and adding deps to satisfy a linter is how a render loop ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Pull Request 🤖
Commits ahead of test: 4
Commits behind test: 0
TODOs remaining in codebase: 4
Last updated: 2026-08-08 17:25:30 UTC