🧪 Auto-PR: Merge develop → test - #988
Merged
Merged
Conversation
Three admin tools were being dropped from every client session. Tool names are
constrained to `^[a-zA-Z0-9_-]{1,64}$`, and a name over the cap is not truncated
— the whole tool is rejected. Nothing on this side notices: the registry lists
it, the route answers fine over HTTP, and it is simply absent wherever the tools
are actually used.
67 delete_admin_healthcare-users_userId_client-roles_clientId_roleName
66 create_admin_healthcare-users_userId_federated-identities_provider
66 delete_admin_healthcare-users_userId_federated-identities_provider
Over the cap, path PARAMETERS are dropped first. They are the least informative
part of a name — each one is already an argument in the tool's input schema,
described there — so shedding them keeps the segments that say what the tool
acts on:
42 delete_admin_healthcare-users_client-roles
50 create_admin_healthcare-users_federated-identities
50 delete_admin_healthcare-users_federated-identities
Only if that still does not fit is the name cut and given a stable FNV-1a digest,
so it stays unique and identical across deploys. A name changing between deploys
would break saved client prompts, which is why the digest is deterministic rather
than crypto or counter based.
Names at or under the cap are returned byte-for-byte as before. The first cut of
this built the name from filtered path segments, which silently dropped the empty
segment of a trailing-slash route and would have renamed 30 live tools
(get_admin_profile_ -> get_admin_profile) to fix 3 unreachable ones. Verified
against the real 180-tool surface: exactly 3 names change, longest is still 61.
Dropping parameters can also make two routes agree on a name, and the registry is
a Map keyed by name — the second would have overwritten the first and a tool
would have vanished with no error anywhere. extractRouteTools now disambiguates
instead of overwriting.
The trailing underscores are left alone deliberately. They are ugly, and fixing
them is a rename of tools clients call today, so it belongs in its own change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Pull Request 🤖
Commits ahead of test: 1
Commits behind test: 0
TODOs remaining in codebase: 3