Skip to content

MAT-9813_MAT-9814: host shared measure action center in madie-util - #217

Merged
etan-sb merged 1 commit into
developfrom
feature/MAT-9813_MAT-9814/admin-user-profile-measure-actions
Jul 29, 2026
Merged

MAT-9813_MAT-9814: host shared measure action center in madie-util#217
etan-sb merged 1 commit into
developfrom
feature/MAT-9813_MAT-9814/admin-user-profile-measure-actions

Conversation

@etan-sb

@etan-sb etan-sb commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

MADiE PR

  • Centralize the Measures-workspace action icons, dialogs, export flow, and CmsIdFormatter so madie-measure and madie-admin share one copy.
  • Add the build support these components need: design-system bundling (orgPackagesAsExternal = false), emotion/styled/react-is externals, scss + svg loaders, the twin.macro toolchain, and the node polyfill.

Jira Ticket: MAT-9813, MAT-9814
(Optional) Related Tickets:

MeasureAuthoringTool/madie-models#303
MeasureAuthoringTool/madie-admin#48
MeasureAuthoringTool/madie-measure#1610

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@etan-sb
etan-sb requested a review from a team as a code owner July 24, 2026 16:49
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.27%. Comparing base (bd363d8) to head (3896e84).

Files with missing lines Patch % Lines
src/components/measureActions/exportUtil.ts 65.95% 9 Missing and 23 partials ⚠️
...measureActions/dialogs/shareDialog/ShareDialog.tsx 91.73% 8 Missing and 13 partials ⚠️
...ctions/dialogs/shareDialog/MultiInputTextField.tsx 84.21% 0 Missing and 3 partials ⚠️
...wMeasureHistoryDialog/ViewMeasureHistoryDialog.tsx 93.18% 0 Missing and 3 partials ⚠️
...asureActions/actions/exportAction/ExportAction.tsx 96.87% 0 Missing and 1 partial ⚠️
...measureActions/actions/shareAction/ShareAction.tsx 98.18% 0 Missing and 1 partial ⚠️
.../compareVersionsDialog/panel/HrComparisonPanel.tsx 95.00% 0 Missing and 1 partial ⚠️
...asureActions/dialogs/exportDialog/ExportDialog.tsx 90.00% 0 Missing and 1 partial ⚠️
...ons/dialogs/viewHumanReadableModal/ViewHRModal.tsx 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #217      +/-   ##
===========================================
- Coverage    99.08%   95.27%   -3.82%     
===========================================
  Files           31       55      +24     
  Lines          767     1503     +736     
  Branches       108      277     +169     
===========================================
+ Hits           760     1432     +672     
- Misses           4       21      +17     
- Partials         3       50      +47     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@etan-sb
etan-sb merged commit 2fec34c into develop Jul 29, 2026
12 of 20 checks passed
@etan-sb
etan-sb deleted the feature/MAT-9813_MAT-9814/admin-user-profile-measure-actions branch July 29, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants