Skip to content

x DTS: fix infinite loop in Extensions() when handler overflows asset boundary #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjuhasz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

x DTS: fix infinite loop in Extensions() when handler overflows asset boundary #2631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c64ff
x DTS: fix infinite loop in Extensions() when handler overflows asset…
Jun 1, 2026
ebf652c
x DTS/XLL: fix root cause of Element_Offset overshoot when LLFrameSiz…
Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Source/MediaInfo/Audio/File_Dts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1692,6 +1692,8 @@ void File_Dts::Extensions()
default:
Extensions_Resynch(false);
}
if (Element_Offset>Element_Size)
Element_Offset=Element_Size; //Prevent unsigned underflow in loop condition if handler left offset past asset boundary
Element_End0();
}
Element_Size=Element_Size_Save;
Expand Down Expand Up @@ -1946,6 +1948,13 @@ void File_Dts::XLL()
return;
}
auto Element_Size_Save=Element_Size;
if (Element_Offset_Start-3+LLFrameSize>Element_Size_Save)

@cjee21 cjee21 Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that Element_Offset_Start - 3+ LLFrameSize can not overflow. Maybe LLFrameSize>Element_Size - Element_Offset_Start - 3 is better?

{
BS_End();
Element_End0();
Skip_XX(Element_Size-Element_Offset, "(Unknown)");
return;
}
Element_Size=Element_Offset_Start-3+LLFrameSize;
Get_S1 (4, NumChSetsInFrame, "NumChSetsInFrame");
NumChSetsInFrame++; Param_Info1(NumChSetsInFrame);
Expand Down