Matroska: preserve LanguageIETF priority regardless of element order - #2645
Open
maghuro wants to merge 1 commit into
Open
Matroska: preserve LanguageIETF priority regardless of element order#2645maghuro wants to merge 1 commit into
maghuro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves a Matroska track's
LanguageIETFvalue regardless of whether the legacyLanguageelement appears before or after it.LanguageIETFis now handled separately and takes precedence overLanguagefor the currentTrackEntry.This applies consistently to video, audio and text tracks.
Why
Previously, both elements used the same handler. When
LanguageIETFappeared first, a later legacyLanguageelement could overwrite a specific BCP 47 tag such asen-USwitheng/en.Validation
git diff --checkpasses.Related to MediaArea/MediaInfo#1295