Skip to content

Revert "[Fix] 회원가입 플로우 오류 수정 #6"#10

Merged
ProtossManse merged 1 commit intomainfrom
revert-7-fix/elder-register-#6
Mar 12, 2026
Merged

Revert "[Fix] 회원가입 플로우 오류 수정 #6"#10
ProtossManse merged 1 commit intomainfrom
revert-7-fix/elder-register-#6

Conversation

@ProtossManse
Copy link
Copy Markdown
Contributor

@ProtossManse ProtossManse commented Mar 12, 2026

Reverts #7

Summary by CodeRabbit

릴리스 노트

  • Refactor

    • 로깅 시스템을 업데이트했습니다.
    • UI 상태 관리를 개선하여 로컬 상태 처리를 강화했습니다.
    • 생년월일 데이터 형식을 표준화했습니다.
  • Chores

    • 외부 로깅 의존성을 제거했습니다.

@ProtossManse ProtossManse merged commit 359a03a into main Mar 12, 2026
2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 656c5ca4-1ac7-4876-abaf-13b36665db66

📥 Commits

Reviewing files that changed from the base of the PR and between 81c2ea9 and 06f9d7a.

📒 Files selected for processing (9)
  • composeApp/build.gradle.kts
  • composeApp/src/androidMain/kotlin/com/konkuk/medicarecall/App.kt
  • composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/data/di/NetworkModule.kt
  • composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/data/mapper/ElderInfoMapper.kt
  • composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/data/mapper/ElderMapper.kt
  • composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/calltime/screen/CallTimeScreen.kt
  • composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/calltime/viewmodel/CallTimeViewModel.kt
  • composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/elder/screen/LoginElderInfoScreen.kt
  • composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/elder/viewmodel/LoginElderViewModel.kt

Walkthrough

이 PR은 Napier 로깅 라이브러리를 제거하고 Kotlinx Logger로 대체하며, 날짜 형식 지정 방식을 변경하고, UI 상태 관리를 개선하는 여러 변경 사항을 포함합니다. 또한 불필요한 guard 조건을 제거하고 import를 정리합니다.

Changes

Cohort / File(s) Summary
Logging 의존성 제거
composeApp/build.gradle.kts, composeApp/src/androidMain/kotlin/com/konkuk/medicarecall/App.kt
Napier 로깅 라이브러리 의존성 제거 및 초기화 호출 삭제.
로거 구현 변경
composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/data/di/NetworkModule.kt
Napier 기반 Ktor 로깅을 Kotlinx Logger.DEFAULT로 교체; 로그 레벨은 BODY 유지.
날짜 형식 변경
composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/data/mapper/ElderInfoMapper.kt, composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/data/mapper/ElderMapper.kt
birthDate 매핑을 formatAsDate() 호출에서 원본 값으로 변경; ElderBulkRegisterRequestDto.ElderInfo.birthDate 타입이 String에서 LocalDate로 변경.
UI 상태 관리 리팩토링
composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/calltime/screen/CallTimeScreen.kt
showBottomSheet와 selectedTabIndex를 로컬 상태로 변경하여 uiState 의존성 감소.
뷰모델 상태 처리 개선
composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/calltime/viewmodel/CallTimeViewModel.kt, composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/elder/viewmodel/LoginElderViewModel.kt
observeElderIds에서 isLoading 토글 제거; LoginElderViewModel의 빈 리스트 guard 조건 제거.
Import 정리
composeApp/src/commonMain/kotlin/com/konkuk/medicarecall/ui/feature/login/elder/screen/LoginElderInfoScreen.kt
painterResource, ElderResidence, GenderType, Relationship 명시적 import 추가.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • librawish808

Poem

📝 로거를 버리고 새것을 얻고,
날짜는 이제 더 깔끔하게,
상태는 로컬로 자유로워졌네! ✨
guard는 떠났고 UI는 행복하고,
리팩토링의 춤이 매끄럽네 💫

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-7-fix/elder-register-#6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant