-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 캘린더 깜빡임, 복약 시간 텍스트 한글화, 통계 화면 드롭다운 수정 #8 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
0405286
81e8af4
197f433
0377225
8a3d903
80b188c
922ed2f
0c71129
4896ba6
3fe1937
de92cbb
4f342f5
395f60e
1cddf91
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,11 +37,19 @@ private fun HomeResponseDto.MedicationDto.toMedicines(): Medicines { | |
| medicineName = type.orEmpty(), | ||
| todayTakenCount = taken, | ||
| todayRequiredCount = goal, | ||
| nextDoseTime = nextTime, | ||
| nextDoseTime = formatNextDoseTimeToKorean(nextTime), | ||
| doseStatusList = doseStatusList?.map { it.toHomeDoseStatus() } ?: emptyList(), | ||
| ) | ||
| } | ||
|
|
||
| private fun formatNextDoseTimeToKorean(nextTime: String?): String? { | ||
| if (nextTime.isNullOrBlank()) return nextTime | ||
| return nextTime | ||
| .replace("MORNING", "아침약") | ||
| .replace("LUNCH", "점심약") | ||
| .replace("DINNER", "저녁약") | ||
|
ProtossManse marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| // Dose DTO → Domain | ||
| private fun HomeResponseDto.DoseStatusDto.toHomeDoseStatus(): HomeDoseStatusList { | ||
| return HomeDoseStatusList( | ||
|
|
@@ -182,9 +190,9 @@ object HomeMapper { | |
|
|
||
| private fun getDefaultNextDose(firstTimeKey: Any?): String { | ||
| return when (firstTimeKey?.toString()?.uppercase()) { | ||
| "MORNING" -> "아침" | ||
| "LUNCH" -> "점심" | ||
| "DINNER" -> "저녁" | ||
| "MORNING" -> "아침약" | ||
| "LUNCH" -> "점심약" | ||
| "DINNER" -> "저녁약" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아침약, 점심약, 저녁약보다는 아침, 점심, 저녁으로 통일하는 게 나을 것 같습니다!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 피그마상 -약으로 표기되어있어서 피그마기준으로 맞춰두었습니다!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아 혹시 enum은 아침/점심/저녁으로 두고 ui표시할때만 약을 붙이라는 의미인가요?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
아 피그마에서 그렇게 돼있으면 아침약, 점심약, 저녁약으로 표기하는게 맞겠네요! |
||
| else -> "-" | ||
| } | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.