Add licensing acknowledgment dialog on startup and update About dialog#2169
Add licensing acknowledgment dialog on startup and update About dialog#2169
Conversation
Integrates the MegaMek Suite licensing dialog into MegaMekLab startup and updates the About dialog to use aligned legal text with clickable links, replacing outdated GPL-only text. Depends on MegaMek PR (Implement-Licensing-Dialog branch). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Integrates MegaMek Suite’s licensing acknowledgment flow into MegaMekLab by showing the shared licensing dialog on startup and aligning MegaMekLab’s About dialog legal text with MegaMek’s message keys (including clickable links).
Changes:
- Show
LicensingDialog.showIfNeeded()during MegaMekLab startup with a “Welcome to MegaMekLab [VERSION]” message. - Update the About dialog to render HTML assembled from MegaMek’s
LicensingDialog.*/CommonAboutDialog.*i18n keys and enable hyperlink navigation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
megameklab/src/megameklab/MegaMekLab.java |
Adds licensing/welcome dialog invocation during startup. |
megameklab/src/megameklab/ui/MenuBar.java |
Reworks About dialog body to use MegaMek legal/community text keys and clickable links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Guard LicensingDialog with !noStartup to prevent blocking batch/CLI runs - Move dialog to after startup screen is visible so both appear together - Use MMLConstants.PROJECT_NAME constant instead of hardcoded string - Use UIUtil.browse() for platform-safe hyperlink handling in MenuBar - Replace duplicate buildAboutHtml() with LicensingDialog.buildLegalHtml() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Copilot feedback addressed in commit 65da303: 1. --no-startup guard — 2. Dialog timing — Moved the dialog call to after the startup screen is displayed, so both appear together instead of the dialog blocking before the main window. Additional fixes:
|
Note: Depends on MegaMek PR (uses LicensingDialog from megamek) MegaMek/megamek#8164
Summary
Integrates the MegaMek Suite licensing dialog into MegaMekLab startup and updates the About dialog to use aligned legal text with clickable links.
Changes
MegaMekLab [VERSION]".
Messages.getString(), replacing outdated GPL-only text.
Files Changed