Skip to content

rebuild cache button#2170

Merged
SJuliez merged 4 commits intoMegaMek:mainfrom
exeea:infantryminmove
Apr 12, 2026
Merged

rebuild cache button#2170
SJuliez merged 4 commits intoMegaMek:mainfrom
exeea:infantryminmove

Conversation

@exeea
Copy link
Copy Markdown
Collaborator

@exeea exeea commented Apr 6, 2026

This adds the rebuild cache button, requires MegaMek/megamek#8169

@exeea exeea requested a review from a team as a code owner April 6, 2026 11:34
Copilot AI review requested due to automatic review settings April 6, 2026 11:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a UI affordance to explicitly rebuild the unit cache (in addition to the existing refresh option), and aligns infantry ground MP printing with updated infantry movement semantics.

Changes:

  • Update the Refresh menu to route “Refresh Unit Cache” through a dialog-backed helper and add “Rebuild Unit Cache”.
  • Add miRebuildUnitCache.text to menu resources.
  • Update PrintInfantry ground MP formatting to use infantry.hasMinimalGroundMP().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
megameklab/src/megameklab/ui/MenuBar.java Adds menu item + helper methods to refresh/rebuild the unit cache via UnitLoadingDialog and MekSummaryCache.
megameklab/src/megameklab/printing/PrintInfantry.java Uses hasMinimalGroundMP() to decide when to print 0* for ground MP.
megameklab/resources/megameklab/resources/Menu.properties Adds the localized label for the new rebuild cache menu item.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SJuliez SJuliez merged commit 928349d into MegaMek:main Apr 12, 2026
7 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (507a555) to head (46e44a7).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #2170   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants