Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a UI affordance to explicitly rebuild the unit cache (in addition to the existing refresh option), and aligns infantry ground MP printing with updated infantry movement semantics.
Changes:
- Update the Refresh menu to route “Refresh Unit Cache” through a dialog-backed helper and add “Rebuild Unit Cache”.
- Add
miRebuildUnitCache.textto menu resources. - Update
PrintInfantryground MP formatting to useinfantry.hasMinimalGroundMP().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| megameklab/src/megameklab/ui/MenuBar.java | Adds menu item + helper methods to refresh/rebuild the unit cache via UnitLoadingDialog and MekSummaryCache. |
| megameklab/src/megameklab/printing/PrintInfantry.java | Uses hasMinimalGroundMP() to decide when to print 0* for ground MP. |
| megameklab/resources/megameklab/resources/Menu.properties | Adds the localized label for the new rebuild cache menu item. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SJuliez
approved these changes
Apr 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2170 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the rebuild cache button, requires MegaMek/megamek#8169