Label: Fix Cursor.Pointer and FileInput.Display property#6511
Label: Fix Cursor.Pointer and FileInput.Display property#6511
Conversation
stsrki
left a comment
stsrki
left a comment
There was a problem hiding this comment.
I would move this to the 2.1 release as it would break the new material and antdesign work anyway, and we need to recreate it there.
| if ( !parameters.TryGetValue<UtilityTarget>( nameof( UtilityTarget ), out _ ) | ||
| && UtilityTarget == UtilityTarget.Self ) | ||
| { | ||
| UtilityTarget = UtilityTarget.Wrapper; |
There was a problem hiding this comment.
This is wrong. We should not assume how each provider will render the component from the core project. That's why we have the UtilityTarget parameter. To have more control.
And then the user can have the option to customize it ONLY IF they need it. This is the last line of defense, so to speak.
| <Field Horizontal> | ||
| <FieldLabel ColumnSize="ColumnSize.IsFull.OnTablet.Is2.OnDesktop">Custom file label</FieldLabel> | ||
| <FieldBody ColumnSize="ColumnSize.IsFull.OnTablet.Is10.OnDesktop"> | ||
| <Control Role="ControlRole.File" Border="Border.Is1.Rounded.Subtle" Padding="Padding.Is1.OnY.Is2.OnX"> |
There was a problem hiding this comment.
The Control component was never meant to be used externally. This is a remnant from the early days of Blazorise that solved some problems(internally) at the time, but it got stuck. So I would remove it from the demo usage.
2 participants
Description
Closes #6509
How Has This Been Tested?
Types of changes
Checklist:
masterfor dev,rel-1.xfor maintenance).